Skip to content

starknet_os: os resources test - deploy account tx calldata factor#14151

Closed
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factorfrom
05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor
Closed

starknet_os: os resources test - deploy account tx calldata factor#14151
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factorfrom
05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

dorimedini-starkware commented May 24, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test and fee-estimation constant updates only; no runtime execution-path changes.

Overview
Extends test_execute_txs_inner_resources so DeployAccount OS costs match how Invoke is already calibrated: a base deploy (minimal constructor calldata) and an extra deploy (one more calldata element), then derives the scaled calldata factor as extra − base while keeping the constant term as the base overhead.

blockifier_versioned_constants_0_14_4.json updates DeployAccount.calldata_factor to the newly measured values (n_steps 37→30, pedersen_builtin 2→1); scaling factor stays 2.

Reviewed by Cursor Bugbot for commit 10ec03a. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch from b4fd833 to 77fc062 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch from 04d3d51 to 5af6585 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch from 77fc062 to b07e51e Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch from 4a6103f to 5e52dfb Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch from b07e51e to 4ff38f8 Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch from 4ff38f8 to 8817938 Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch 2 times, most recently from 8b5651e to 9585e9f Compare June 1, 2026 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch from 4337967 to 84efb70 Compare June 2, 2026 10:21
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch from 9585e9f to 10ec03a Compare June 2, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants